[Ntop-misc] Transparent mode hard-coded into SVN Version of PF_RING?

[Dedi Hirschfeld]

Hi

It looks like the last several versions of  PF_RING have transparent
mode hard-coded into them. Specifically, line 1288 of the latest version
of ring_packet.c  has a '#if 0' in it, so that on every return from
skb_ring_handler, RC = 0, telling the network driver that the packet
needs to be handled.
Looking at the SVN history for that file, I see that non-transparent
mode has been disabled since version 3290 (Checked in on sep. 12th of
this year). The comment for that check in just says that it contains
fixes for kernel 2.6.9.
When removing the '#if' to make non-transparent mode work, I ran into
the memory leak issue described in
http://www.gossamer-threads.com/lists/ntop/misc/20465?search_string=noamdev;#20465.
After restoring the  call to dev_kfree_skb(), everything seems to work
fine in the limited tests I did. I'm still a bit worried about going
further with this. Can anyone tell me why was non-transparent mode disabled?