[Ntop-dev] [opal@debian.org: Bug#316886: NTop Bugs]

[Burton Strauss]

Well, it pretty clearly IS a bug in the apache proxy - just like you would
expect ln -s or mount to attach a COMPLETE directory tree, not just bits and
pieces of it...


Let's see...

(1) You'll have to discuss it with Luca - I tried this at one point and he
reversed out my patches.

(2) Fixed paths make it much easier to code ntop so that we don't have to
worry about directory traversal issues.

All pages are either in ../html, it's subdirectories or are generated
internally (and it's that last that makes it a pain to track relative
paths).

As to how hard, not technically difficult, but not easy either.  The /s are
all throughout the code, but it shouldn't be THAT hard to make it a #define
parameter.  That could cause a rash of tiny bugs as other stuff gets exposed
via relative paths, esp. WRT plugins.


-----Burton

-----Original Message-----
From: ntop-dev-bounces at unipi.it [mailto:ntop-dev-bounces at unipi.it] On Behalf
Of Ola Lundqvist
Sent: Tuesday, July 05, 2005 3:27 AM
To: ntop-dev at Unipi.IT
Subject: Re: [Ntop-dev] [opal at debian.org: Bug#316886: NTop Bugs]

On Mon, Jul 04, 2005 at 05:12:01PM -0500, Burton Strauss wrote:
> What - that ntop uses absolute paths?  That's the way it's coded...

Ok I see. In this case it become a problem. I marked this bug as a wishlist
bug (as it is a new feature) though.

Would it be hard to change this to non-absolute?

It could also be seen as a bug in the apache proxy.

Regards,

// Ola

> -----Burton
> 
> 
> -----Original Message-----
> From: ntop-dev-bounces at unipi.it [mailto:ntop-dev-bounces at unipi.it] On 
> Behalf Of Ola Lundqvist
> Sent: Monday, July 04, 2005 11:13 AM
> To: ntop-dev at Unipi.IT
> Cc: control at bugs.debian.org
> Subject: [Ntop-dev] [opal at debian.org: Bug#316886: NTop Bugs]
> 
> forwarded #316886 ntop-dev at unipi.it
> thanks
> 
> Hello
> 
> Is this a known problem?
> 
> Regards,
> 
> // Ola
> 
> ----- Forwarded message from Ola Lundqvist <opal at debian.org> -----
> 
> Envelope-to: ola at opalsys.net
> Delivery-date: Mon, 04 Jul 2005 17:55:40 +0200
> Subject: Bug#316886: NTop Bugs
> Reply-To: opal at debian.org, 316886 at bugs.debian.org
> Resent-From: Ola Lundqvist <opal at debian.org>
> Resent-To: debian-bugs-dist at lists.debian.org
> Resent-CC: Ola Lundqvist <opal at debian.org>
> Resent-Date: Mon, 04 Jul 2005 15:48:02 UTC
> Resent-Message-ID: <handler.316886.B.1120491690626 at bugs.debian.org>
> X-Debian-PR-Message: report 316886
> X-Debian-PR-Package: ntop
> X-Debian-PR-Keywords: 
> From: Ola Lundqvist <opal at debian.org>
> To: Matthias Fenner <informix at web.de>
> Cc: submit at bugs.debian.org, ntop-dev at unipi, it at opalsys.net
> X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
> 	(1.212-2003-09-23-exp) on spohr.debian.org
> X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
> 	autolearn=no version=2.60-bugs.debian.org_2005_01_02
> X-Spam-Level: 
> Resent-Sender: Debian BTS <debbugs at bugs.debian.org>
> X-Spam-Score: 0.5 (/)
> X-Spamcheck-provider: Checked for spam by opalsys.net, 
> postmaster at opalsys.net
> 
> Package: ntop
> Severity: wishlist
> Version: 2:3.0-5
> 
> Hello
> 
> I have now created a Debian bugreport for your, so I do not forget 
> about this issue.
> 
> On Thu, Jun 23, 2005 at 07:09:26PM +0200, Matthias Fenner wrote:
> > ----------  Virus-checked by ClamAV at QServer  ----------
> > 
> > Hello there!
> > 
> > I´ve dicoverd serverl problems with the absolut image-pathes in the 
> > ntop-web-server.
> > 
> > When you use apache to passive-proxy localhost:3000/ to /ntop/ ,
> > 
> > ntop slows down and doesnt find serveral images (du to the 
> > absolut-path of
> > images) just look at this:
> > 
> >  grep white_bg.gif -r /usr/share/ntop/ | nl
> > 
> > quiet annoying, isnt it ?
> 
> I have not relocated the location to something else so you are 
> probably right. I'll cc the ntop development list too.
> 
> Regards,
> 
> // Ola
> 
> > --
> > Mit freundlichem Gruß
> > 		_Matthias Fenner_
> > 		[www.Fenner.info]
> > fo]
> > 
> 
> >--------------------------------------------------------
> >root at qserver:~# apt-cache show ntop
> >
> >Package: ntop
> >Priority: optional
> >Section: net
> >Installed-Size: 6372
> >Maintainer: Ola Lundqvist <opal at debian.org>
> >Architecture: i386
> >Version: 2:3.0-5
> >Depends: libc6 (>= 2.3.2.ds1-4), libfreetype6 (>= 2.1.5-1), 
> >libgd2-noxpm (>= 2.0.33) | libgd2-xpm (>= 2.0.33), libgdbm3, 
> >libjpeg62, libpcap0.7, libpng12-0 (>= 1.2.8rel), libssl0.9.7, zlib1g 
> >(>= 1:1.2.1), debconf (>=
> 0.2.26)
> >Filename: pool/main/n/ntop/ntop_3.0-5_i386.deb
> >Size: 2401872
> >MD5sum: b064b5cdacb431e13a97b7b22c3f3d73
> >--------------------------------------------------------
> 
> Regards,
> 
> // Ola

<snip />